Allow logging behavior to be configured at runtime, by supporting a SINGER_LOGGING_CONF environment variable. This enables downstream developers to provide their own version of logging.conf to match the needs of their projects.
Without this change, logging configuration is hard coded in logging.conf, which is loaded within logger.getLogger(). This makes it very difficult to change logging settings at runtime. Even taps and targets that attempt to support customization fail to do so properly since multiple invocations of logger.getLogger() will simply reload the hard coded settings (target-postgres is an example).
Manual QA steps
Run a singer tap or target, and confirm that it logs as usual
Copy logging.conf to a separate file and change the log format to something noticeably different
Set the SINGER_LOGGING_CONF environment variable to contain the absolute path of your new logging.conf
Run the singer tap or target again, and confirm that it logs with your customized log format
Description of change
Allow logging behavior to be configured at runtime, by supporting a
SINGER_LOGGING_CONFenvironment variable. This enables downstream developers to provide their own version oflogging.confto match the needs of their projects.Without this change, logging configuration is hard coded in
logging.conf, which is loaded withinlogger.getLogger(). This makes it very difficult to change logging settings at runtime. Even taps and targets that attempt to support customization fail to do so properly since multiple invocations oflogger.getLogger()will simply reload the hard coded settings (target-postgres is an example).Manual QA steps
logging.confto a separate file and change the log format to something noticeably differentSINGER_LOGGING_CONFenvironment variable to contain the absolute path of your newlogging.confRisks
Rollback steps