singer-io / singer-python

Writes the Singer format from Python

https://singer.io

Apache License 2.0

538 stars 128 forks source link

allow more recent versions from jsonschema #150

Closed modularTaco closed 3 years ago

modularTaco commented 3 years ago

Description of change

singer-python requires jsonschema in version 2.6.0.
Version 2.6.0 is from 2017 and only supports jsonschemas up to draft 4.
This PR sets jsonschema version 2.6.0 as minimum required version so newer versions are allowed.

Otherwise singer targets which use the singer-python package cannot use a jsonschema validator for new jsonschema versions.

Manual QA steps

Risks

Rollback steps

revert this branch

cmerrick commented 3 years ago

Hi @modularTaco, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

cmerrick commented 3 years ago

You did it @modularTaco!

Thank you for signing the Singer Contribution License Agreement.

modularTaco commented 3 years ago

Already handled in https://github.com/singer-io/singer-python/pull/135, sorry