Use disable_existing_loggers in logger

singer-io / singer-python

Writes the Singer format from Python

https://singer.io

Apache License 2.0

537 stars 129 forks source link

Use disable_existing_loggers in logger #78

Closed timvisher closed 5 years ago

timvisher commented 5 years ago

Motivation

This allows external modules to use the logging facilities.

timvisher commented 5 years ago

@iterati It looks like you touched most of logger.py last. Do have any idea if this is a bad thing or not? Needed in support of https://github.com/singer-io/tap-stripe/commit/7713063c3b88970e3433e26f0817fa60fd49d07c

iterati commented 5 years ago

I don't see anything wrong with this. Maybe make disable_existing_loggers a kwarg with True as the default so older taps don't change their behavior? I don't think it's necessary, though.

luandy64 commented 5 years ago

Closed by https://github.com/singer-io/singer-python/commit/e4b892b223c75df6dad7be966bc056a15156ce69