Deprecate `utils.strptime`

singer-io / singer-python

Writes the Singer format from Python

https://singer.io

Apache License 2.0

542 stars 130 forks source link

Deprecate `utils.strptime` #82

Closed timvisher closed 6 years ago

timvisher commented 6 years ago

Motivation

This appears to have been deprecated for some time and is poorly behaved in the case of fractional seconds. utils.strptime_to_utc is preferred anyway.

See https://github.com/singer-io/singer-python/issues/81

Implementation Notes

Move to circle 2.0
Add doctest to the nose runner
Add a docstring and warn call to utils.strptime

timvisher commented 6 years ago

For some reason circle isn't running this.

(singer-python) vagrant@taps-tvisher1:/opt/code/singer-python$ circleci local execute
…
Ran 90 tests in 0.396s

OK
Success!

timvisher commented 6 years ago

The meat here is really https://github.com/singer-io/singer-python/pull/82/files#diff-7bab99d622479da29fc9fc39cb1058f7R29