singer.read_tap - read from a tap programatically

singer-io / singer-python

Writes the Singer format from Python

https://singer.io

Apache License 2.0

537 stars 129 forks source link

singer.read_tap - read from a tap programatically #85

Closed OriHoch closed 5 years ago

OriHoch commented 5 years ago

Adds a singer.read_tap method which starts a tap using subprocess.Propen and yields Message objects from it

Doesn't handle errors / exceptions

See read_tap function documentation and tests for more details.

related issue: #84

timvisher commented 5 years ago

Thanks! We'll review this asap and send any feedback we have your way. :)

OriHoch commented 5 years ago

thanks @dmosorast your comments make sense :+1: I'm just not sure when I'll get around to implement the changes.. hopefully in a week or two

timvisher commented 5 years ago

@OriHoch Think you'll have any time to work on this in the next week or so? If not it's NBD we can close the PR/Issue out for now and when you have time to pick it back up we can get it going again.

Thoughts?

timvisher commented 5 years ago

We'll close this out so we get re-notified if work picks back up on it. :)