singer-io / singer-python

Writes the Singer format from Python
https://singer.io
Apache License 2.0
537 stars 129 forks source link

Init logger #90

Open mplovepop opened 5 years ago

mplovepop commented 5 years ago

Initialize the singer root logger once

Only initialize the logger once, and only if the _INIT_LOGGER module private variable is True. The reason for this is to allow client applications to override logging with custom formatters (& more) when necessary. For instance, to use eliot[1] to log but take advantage of the metrics and timers supplied by singer-python.

[1] eliot: https://eliot.readthedocs.io/en/stable/

Disable pylint global warning for _INIT_LOGGER

An alternative would be to cache the results of get_logger, but this feels cleaner and more explicit to me.

abij commented 4 years ago

+1, Seems good to me.