search

singer-io / singer-tap-template

GNU Affero General Public License v3.0
68 stars 30 forks source link

updated class usage, expanded sync() sample #11

Closed aaronsteers closed 4 years ago

aaronsteers commented 4 years ago

Description of change

Replaces #10, resolves #8. Replaces custom json manipulation functions with updated class methods and uses the central singer-python library wherever possible. Also adds a more detailed example sync() function, including a sample batch operation and dummy data used as placeholders for real data.

Manual QA steps

In a separate project (WIP) I was able to test these functions successfully, then copy-pasted from that project back into this one.

Risks

Rollback steps

dmosorast commented 4 years ago

@aaronsteers Hi, sorry about the radio silence. It seems Github wasn't notifying me of your responses. I'll see if I can get that fixed.

Added responses to your comments.

aaronsteers commented 4 years ago

@dmosorast - Great - thanks so much! I've made all suggested updates, and this should be ready again for review. Lmk if anything further needs updating.

aaronsteers commented 4 years ago

@dmosorast - Thanks so much for your support! Excited to see this merged. 😎