TypeError due to trying to find max between None with non None value

singer-io / singer-tap-template

GNU Affero General Public License v3.0

68 stars 32 forks source link

TypeError due to trying to find max between None with non None value #19

Open pvonglehn opened 1 year ago

pvonglehn commented 1 year ago

If a bookmark column is set the a TypeError is always thrown when running the tap.

As max_bookmark is initially set to None, when we try to see if max_bookmark needs updating by comparing it to the first value of the bookmark column a TypeError is thrown:

TypeError: '>' not supported between instances of 'int' and 'NoneType'