search

singer-io / singer-tap-template

GNU Affero General Public License v3.0
68 stars 30 forks source link

Remove Legacy Properties Option #4

Closed dmosorast closed 5 years ago

dmosorast commented 6 years ago

The template differentiates between properties and catalog and will accept both. However, the --properties argument is deprecated in the Singer spec, and if it's passed in, then taps written with this template expecting the catalog will not function.

I would like to propose removing the properties argument handling here since all new taps should conform to the latest standards.

zenkay commented 5 years ago

Hi @dmosorast! I suppose that #5 close this issue. Is that right? I'm going to start developing a tap and I was checking the issues first 😉

dmosorast commented 5 years ago

@zenkay You are correct! I guess this got overlooked when that was merged. Thanks for letting me know! Closing this one.