search

singer-io / tap-appsflyer

A Singer.io tap for extracting data from the AppsFlyer API
GNU Affero General Public License v3.0
11 stars 40 forks source link

updated version of requests library #13

Closed mbreault closed 5 years ago

mbreault commented 5 years ago

Our security team got an alert about a cve in https://github.com/singer-io/tap-appsflyer/blob/master/setup.py. specifically that 'requests==2.12.4', should be updated to 2.20.0 or newer.

cmerrick commented 5 years ago

Hi @mbreault, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

dmosorast commented 5 years ago

Thanks for the submission @mbreault! I'm prepared to merge this once we get confirmation about the contribution agreement.

mbreault commented 5 years ago

Thanks for the submission @mbreault! I'm prepared to merge this once we get confirmation about the contribution agreement.

I completed the contribution agreement the day I did the PR. Is there something else I need to do?

dmosorast commented 5 years ago

@mbreault Ah! I see now. The webhook must have been dropped at the time so I didn't receive the notification. Sorry for the delay, thanks a bunch! I'll get this merged now.

cmerrick commented 5 years ago

You did it @mbreault!

Thank you for signing the Singer Contribution License Agreement.