fix date related issues and make timezone aware

singer-io / tap-appsflyer

A Singer.io tap for extracting data from the AppsFlyer API

GNU Affero General Public License v3.0

11 stars 40 forks source link

fix date related issues and make timezone aware #17

Closed robinj closed 11 months ago

robinj commented 5 years ago

Fix issues found in PR #15

replace calls to deprecated strptime with strptime_to_utc
make all dates timezone aware so that comparisons work

cmerrick commented 5 years ago

Hi @robinj, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

cmerrick commented 5 years ago

You did it @robinj!

Thank you for signing the Singer Contribution License Agreement.

joraniedemagit commented 4 years ago

@cmerrick has this been merged yet?

robinj commented 11 months ago

Since this PR has been opened for five years with no review, I will close it to tidy up my PR list

rdeshmukh15 commented 11 months ago

@robinj : reviewing it now