singer-io / tap-appsflyer

A Singer.io tap for extracting data from the AppsFlyer API

GNU Affero General Public License v3.0

11 stars 40 forks source link

Change event revenue attributes to type: numeric #25

Open mhimi1 opened 4 years ago

mhimi1 commented 4 years ago

event_revenue and event_revenue_usd are of type string. This causes issues in BigQuery when doing sums. Changed to numeric

Description of change

event_revenue and event_revenue_usd are of type string. This causes issues in BigQuery when doing sums. Changed to numeric

Manual QA steps

Risks

Unsure whether this would break non BigQuery integrations?

Rollback steps

revert this branch

gaberogan commented 3 years ago

With this I get:

singer.transform.SchemaMismatch: Errors during transform
    event_revenue: 2.99 does not match {'type': ['numeric', 'null']}

It seems that 2.99 is somehow a string and Singer doesn't like transforming it to a number. I'm not very familiar with how this process should work but it seems this PR needs to handle this better.