singer-io / tap-bing-ads

A Singer.io tap for extracting data from the Bing Ads API
GNU Affero General Public License v3.0
13 stars 30 forks source link

Add optional 'tenant' config option #111

Open robotfelix opened 11 months ago

robotfelix commented 11 months ago

Description of change

Providing the "tenant ID" of a single tenant (single organization) app is necessary for successful authentication, as they cannot be authorized via the /common endpoint. Additionally, a developer cannot easily choose to configure an app intended for internal use only as a multi-tenant app to work around this, because multi-tenant apps now require signing up as a Microsoft Partner.

This PR allows new "tenant" config option to be passed to specify a "tenant ID" to use, which is already a supported by the underlying Bing Ads API Python SDK. The config option is entirely optional, and it defaults to "common" to preserve existing behaviour by default ("common" is the value the Bing Ads API Python SDK is already using by default since this tap is currently not providing the optional argument).

Manual QA steps

Risks

Rollback steps

singer-bot commented 11 months ago

Hi @robotfelix, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.