search

singer-io / tap-bing-ads

A Singer.io tap for extracting data from the Bing Ads API
GNU Affero General Public License v3.0
13 stars 30 forks source link

Update API to v13 #36

Closed judahrand closed 4 years ago

judahrand commented 4 years ago

Description of change

As I linked to in Issue #35 v12 of the Bing Ads API was deprecated on 31st October. I believe that the only significant change from the perspective of this project is the removal of the Languages field at the top level of the reports request. This has been moved to a report level filter on some reports.

Please do let me know if I missed any other breaking changes, I have tested that this change does still allow data to be pulled for at least a subset of reports.

Manual QA steps

Risks

Rollback steps

cmerrick commented 4 years ago

Hi @Jude188, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

cmerrick commented 4 years ago

You did it @Jude188!

Thank you for signing the Singer Contribution License Agreement.

judahrand commented 4 years ago

@cmerrick