singer-io / tap-bing-ads

A Singer.io tap for extracting data from the Bing Ads API
GNU Affero General Public License v3.0
13 stars 30 forks source link

Only resume requests from STATE if they are non-null #38

Closed dmosorast closed 4 years ago

dmosorast commented 4 years ago

Description of change

This is a large inefficiency when many account IDs are selected. Each one, per report, will try to resume with a null request ID, even though that is guaranteed to fail.

This PR adds a check to only resume from a request ID that is not null.

Manual QA steps

Risks

Rollback steps