singer-io / tap-bing-ads

A Singer.io tap for extracting data from the Bing Ads API

GNU Affero General Public License v3.0

13 stars 30 forks source link

Add table-key-properties to key_property #72

Open EmaLoprevite opened 3 years ago

EmaLoprevite commented 3 years ago

Description of change

Allow table-key-properties to be added to the metadata and put into key_property in the SCHEMA, this way a target will be able to read the primary keys.

Manual QA steps

Run the tap and look at the final SCHEMA.

Risks

None, if table-key-properties is not defined, it will default to [].

Rollback steps

Revert this branch.

ilkkapeltola commented 2 years ago

@kspeer825 could you have a look at this. This PR would make the tap significantly more useful when the target knows which primary keys to use in reports. Without this, I cannot load into Snowflake as there's no information on primary keys.