singer-io / tap-bing-ads

A Singer.io tap for extracting data from the Bing Ads API

GNU Affero General Public License v3.0

12 stars 28 forks source link

Add retry logic for failures in discovery and sync #81

Closed HarrisonMarcRose closed 3 years ago

HarrisonMarcRose commented 3 years ago

Description of change

We receive 500s from bing ads which cause the tap to fail and therefor the test to fail. Although this is a bing-ads issue there should be retry logic in the tap to add additional success and an issue has been created for that https://jira.talendforge.org/browse/TDL-7402

For stability purposed of the test we are going to add retry logic in the test (which will cover up this issue). This PR implements https://jira.talendforge.org/browse/TDL-14720.

We should consider if this should be removed once the tap ticket is completed.

Manual QA steps

Ran tap-bing-ads test suite

Risks

Not all issues may be tap related issues which means this test could still have stability issues.
This will cover up real tap issues that happen inconsistently

Rollback steps

revert this branch