singer-io / tap-bing-ads

A Singer.io tap for extracting data from the Bing Ads API

GNU Affero General Public License v3.0

12 stars 28 forks source link

TDL-9902 removed the automatic fields from ad ext report #85

Closed namrata270998 closed 2 years ago

namrata270998 commented 2 years ago

Description of change

Removed the constraint imposed on AdExtensionDetailReport of having 'Ctrl', 'Clicks', and 'Impressions' from the required fields in the reports.py

Manual QA steps

Check that the automatic fields test runs without any failures
Check that the catalog generated has available inclusion property for Ctr, Clicks, and Impression fields for AdExtensionDetailReport

Risks

Rollback steps

revert this branch

karanpanchal-crest commented 2 years ago

@umangagrawal-crest @namrata270998 As discussed with Krishnan, please add a comment in the JIRA regarding what needs to be added to the documentation or the behavioral change incorporated as part of this PR

namrata270998 commented 2 years ago

@kspeer825 Sure will merge this PR after the #91 gets merged.

namrata270998 commented 2 years ago

I can approve this when the dependencies are brought in from #91. I am not able to keep up with the changes across PRs to reconcile the differences. Ya'll are too fast for me with these PRs. In the future we will try to organize the Jira tickets so that there is a clear order of operations and one ticket will not unexpectedly block another after the fact.

@kspeer825 we merged the code of PR 91 here and the build is passing, can you please review it now?