singer-io / tap-bing-ads

A Singer.io tap for extracting data from the Bing Ads API

GNU Affero General Public License v3.0

13 stars 30 forks source link

Tdl 7402 add retry logic for 500 errors #89

Closed prijendev closed 3 years ago

prijendev commented 3 years ago

Description of change

Added retry logic for following error
- ConnectionResetError
- socket.timeout
- HTTP Error 408: Request Timeout
- HTTP Error 500: Internal Server Error
- ssl.SSLEOFError: EOF

Manual QA steps

Raise error manually as below,
- socket.error(104, 'Connection reset by peer')
- raise socket.timeout()
- raise HTTPError('url', 408, 'Request Timeout', {}, f)
- raise HTTPError('url', 500, 'Internal Server Error', {}, f)
- raise TransportError('url', 500, 'Internal Server Error')
- raise ssl.SSLEOFError('EOF occurred in violation of protocol')

Risks

Rollback steps

revert this branch

prijendev commented 3 years ago

Closing due to merge issue.