search

singer-io / tap-bing-ads

A Singer.io tap for extracting data from the Bing Ads API
GNU Affero General Public License v3.0
13 stars 30 forks source link

Tdl 9721 missing top level breadcrumb for all streams #91

Closed dbshah1212 closed 2 years ago

dbshah1212 commented 3 years ago

Description of change

Manual QA steps

Risks

Rollback steps

karanpanchal-crest commented 2 years ago

@dbshah1212 Why is the CircleCI build failing for this PR?

dbshah1212 commented 2 years ago

I believe more of the standard assertions can for discovery can be applied in the tap-tester test now. Per this comment https://jira.talendforge.org/browse/TDL-9721?focusedCommentId=1003711&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-1003711 it looks like replication key and primary keys are now properly set in metadata but the test is only verifying against primary keys.

Yes @kspeer825, updated the replication keys in the base file as there is already a discrepancy in primary keys and replication keys and we already created a card for the same: https://jira.talendforge.org/browse/TDL-15816. And uncommented replication key test and it's passing now.