This PR is to bring the tap up to modern methods of authentication. Currently, the code prefers the old method unless told via a config option which will fail after March 1st.
This PR does a couple of things:
Removes the config option in preference of feature detection with the refresh token
Tries the modern method (Microsoft Identity Platform, which is the default for the client library and uses the "offline_access https://ads.microsoft.com/msads.manage" scopes) then catches the exception thrown if the connection hasn't been re-authed with the newest scope and falls back to the original scope.
Manual QA steps
Created a connection authenticated against the bingads.manage and the "offline_access https://ads.microsoft.com/msads.manage" scopes.
Ran the tap without the try/catch with both, the old scope token fails
Ran with the try/catch and both connections succeeded
Risks
Low, this shouldn't cause issues until potentially March 1st if something has been missed.
Description of change
This PR is to bring the tap up to modern methods of authentication. Currently, the code prefers the old method unless told via a config option which will fail after March 1st.
This PR does a couple of things:
"offline_access https://ads.microsoft.com/msads.manage"scopes) then catches the exception thrown if the connection hasn't been re-authed with the newest scope and falls back to the original scope.Manual QA steps
bingads.manageand the"offline_access https://ads.microsoft.com/msads.manage"scopes.Risks
Rollback steps