search

singer-io / tap-chargify

GNU Affero General Public License v3.0
2 stars 16 forks source link

Missing attributes in events stream #25

Closed cirotix closed 3 years ago

cirotix commented 3 years ago

The events stream has an event_specific_data property that has a different schema for each type of event.

Currently only the attributes product_id and account_transaction_id are declared. That means that all the attributes for the other type of event will be ignored (see https://reference.chargify.com/v1/events/events-intro#events-fields-and-event-type for the type of event).

Chargify does not publish the schema for each event type. However, I am speaking with them to have it and will submit a PR with the full specification.

zachharris1 commented 3 years ago

Was this issue resolved by #28 (which was merged into master via #31 )? If thats the case, this issue is resolved.

cirotix commented 3 years ago

Yes it was resolved by #28 / #31. I am not 100% sure the all the events properties have been added (still waiting for Chargify official schema) but this issue can be closed. I will open a new PR should there are some missing properties when I will have an answer from Chargify.