search

singer-io / tap-chargify

GNU Affero General Public License v3.0
2 stars 16 forks source link

Update subscriptions.json #49

Closed rgmills closed 1 year ago

rgmills commented 1 year ago

Fix schema definition for customer resource on subscriptions

Description of change

This replaces https://github.com/singer-io/tap-chargify/pull/46

This makes the customer resource on the subscription schema inline with the customer schema.

https://github.com/singer-io/tap-chargify/blob/master/tap_chargify/schemas/customers.json#L119C1-L125C7

The difference is subscription.customer.portal_invite_last_accepted_at was set to a number however the property on the customer is actually a date-time.

Manual QA steps

Risks

Rollback steps

/cc @sgandhi1311

singer-bot commented 1 year ago

Hi @rgmills, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

singer-bot commented 1 year ago

You did it @rgmills!

Thank you for signing the Singer Contribution License Agreement.

sgandhi1311 commented 1 year ago

Hey Robert, thanks for your contribution! I will review the change and plan the deployment on Monday.

rgmills commented 1 year ago

Thanks @sgandhi1311 , I appreciate it!

sgandhi1311 commented 1 year ago

Hey Robert, I deployed the change on Monday. It seems the issue is fixed, please verify your connection.

rgmills commented 1 year ago

@sgandhi1311 Thanks! I confirmed this morning and we're in good shape. Thank you so much!