Open kayelow opened 4 years ago
Hi @kayelow, thanks for your contribution!
In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.
You did it @kayelow!
Thank you for signing the Singer Contribution License Agreement.
@cmerrick Hi! I signed the CLA, and it looks like it was received, but let me know if there's anything else you need from me or any feedback you have.
Hello all ! Is there any reason that this PR is still pending ? More globally, the question arises for the entire repository's maintenance (not used, workaround, known OS alternatives ?) Thanks 🙏
Description of change
Fixes #4 -- updating the package build to include the metadata files.
I included a few small fixes for bugs I ran into trying to get the PyPI package to run so it should run with normal use, including fixing runs using the catalog generated by discovery mode. It looks like the metadata naming convention was changed previously, so to get it working without these changes I had to manually update the metadata references in the generated catalog to use
currency
instead oftap-criteo.currency
. The catalog itself also wasn't referenced correctly when it was provided as an argument, and it was saving the bookmark instate.json
with an incorrect format that made subsequent runs after the first fail.Manual QA steps
python3 setup.py sdist bdist_wheel
and ensurebuild/lib/tap_criteo/metadata
exists.python3 -m tap_criteo.__init__ -c ../criteo_config.json --discover > catalog.json
python3 -m tap_criteo.__init__ -c ../criteo_config.json --catalog ../catalog.json --state ../state.json | ../virtualenv/target-csv/bin/target-csv
and ensure output contains fields as expected.Risks
Rollback steps