search

singer-io / tap-facebook

Singer.io tap for Facebook Marketing API
GNU Affero General Public License v3.0
110 stars 141 forks source link

Access to "by hour" insights #53

Open juan-m12i opened 5 years ago

juan-m12i commented 5 years ago

Hi, I already left a message in the Singer Slack space, but I am reposting here in case it's a better way to reach out.

I've been exploring ways to get Facebook ads data with using the hourly breakdown (didn't find it neither Stitch nor tap-facebook).

I already made a version that works for me, and I was wondering if I can and should create a fork and submit a PR to get that incorporated in the project (maybe there is a rationale why this wasn't done in the past, so before doing anything I wanted to ask what would be the right steps).

In the middle of coming to my solution I had to do a small tweak to the schema files for the existing reports, so I'd like to talk to a maintainer to understand if I should have actually done something different to correct the problem I was having (basically I was getting errors when parsing a particular field that expected a date-time and facebook was sending a date, so had to edit the tap-facebook schemas in my local copy to make it work).

Looking forward to hearing from you. Best, juan

aiguofer commented 5 years ago

@juan-m12i hey, could you create a PR from your own fork with your changes? we can take a look and go from there.

Thanks!