search

singer-io / tap-fullstory

A Singer tap for extracting data from the FullStory API
GNU Affero General Public License v3.0
7 stars 9 forks source link

Add new fields; refine 429 handling #6

Closed jameremo closed 5 years ago

jameremo commented 5 years ago

This PR has two distinct parts:

  1. It adds a series of fields to the schema that have been added to the FullStory data export since the creation of this tap. 2 It refines handling of 429 errors to better account for FullStory's rate limiting, which allows for a burst of 50 downloads, then subsequently rate limits the downloads to 2/min.
cmerrick commented 5 years ago

Hi @jameremo, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

cmerrick commented 5 years ago

You did it @jameremo!

Thank you for signing the Singer Contribution License Agreement.

timvisher commented 5 years ago

Fixes https://github.com/singer-io/tap-fullstory/issues/5

nick-mccoy commented 5 years ago

Hey @jameremo -- wanted to check in and see if any progress has been made on the requested changes. We'll probably close this in a few days if we don't hear back, but you can reopen at any point if you resume work on this.

jameremo commented 5 years ago

@nick-mccoy I do plan to come back and finish this up, but it might be a few weeks. If you need to close this in the interim that's fine, I'll just reopen when I have time to work on it. Thanks!

timvisher commented 5 years ago

Totally understandable. We'll close this out so we get re-notified when things get going again. :)