Closed migstopheles closed 4 years ago
Hi @migstopheles, thanks for your contribution!
In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.
You did it @migstopheles!
Thank you for signing the Singer Contribution License Agreement.
@cmerrick is this OK to be merged or are there more steps required?
Hello folks 👋 ,
I'm getting similar problems with Decimal
conversions.
Anything I can do to help with this PR?
We could really, really do with getting this merged so we can use this tap properly. It's currently unusable for us without this fix. Is anyone able to help?
@dmosorast @KAllan357 @cmerrick sorry for the :postal_horn: but does anyone know how i can get this PR approved and merged? thanks
Thanks for merging this @KAllan357. You've made a bunch of engineers and data scientists at TravelNest very happy! 😄
Description of change
~3 years ago,
singer-python
was patched to fix issues with the standard JSON encoder failing to encode Decimal types.Bumping the version of
singer-python
to its max minor version (1.9.1) should fix this issue.Example error
Manual QA steps
Risks
Rollback steps