search

singer-io / tap-gitlab

GNU Affero General Public License v3.0
15 stars 19 forks source link

Fix/ignore disabled repository #14

Open sambattalio opened 5 years ago

sambattalio commented 5 years ago

Now that Gitlab API returns a 404 status on disabled repository instead of 403, it seems beneficial to only give warnings on disabled repositories instead of throwing an error for GET /branches and /commits.

cmerrick commented 5 years ago

Hi @sambattalio, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

cmerrick commented 5 years ago

You did it @sambattalio!

Thank you for signing the Singer Contribution License Agreement.

awarzon commented 5 years ago

Thanks for reviewing this @cmerrick ! Do you have an idea of when it'll be merged?