Transform string to unicode

singer-io / tap-gitlab

GNU Affero General Public License v3.0

15 stars 19 forks source link

Transform string to unicode #3

Closed fenekku closed 7 years ago

fenekku commented 7 years ago

Unicode strings like u"S\xe9bastien" breaks this tap. This commit is one take on solving that issue.

cmerrick commented 7 years ago

Hi @fenekku, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

fenekku commented 7 years ago

The 2 contributions were meant as very small fixes. I allow you to use them/redistribute them. However I feel uncomfortable going through this formal and legal binding signing process only for these 2 1-liners, so I won't be completing the online form. Hopefully you can find the issues yourselves and correct them.

Thanks,