search

singer-io / tap-harvest

A Singer tap for extracting data from the Harvest API
GNU Affero General Public License v3.0
8 stars 13 forks source link

Paging not supported for invoices. #17

Closed gduchesneau closed 6 years ago

gduchesneau commented 6 years ago

The first time this integration is run it will query the Harvest API endpoint for invoices updated since the "start date" for the integration (from stitchdata).

Ex: for a start date = jan 1st, 2013 the query looks like : https://ingeno.harvestapp.com/invoices?updated_since=2013-01-01+05%3A00 in the integration log.

The problem with that is that the Harvest API end point for invoices returns 50 invoices max per "request". So this tap should normally use the query parameter "page" to fetch older invoices up to the integration start date.

We have hundreds of invoices in our Harvest account. The consequence is that we only get the latest 50 invoices during the initial load.

dmosorast commented 6 years ago

Closing this as #20 was merged.