search

singer-io / tap-harvest

A Singer tap for extracting data from the Harvest API
GNU Affero General Public License v3.0
8 stars 13 forks source link

remove faulty started_time fields #59

Closed Jaglyser closed 6 months ago

Jaglyser commented 1 year ago

Description of change

Currently if a user is running a timer on Harvet, and you try to extract all data and import it into a data source such as Snowflake the format time breaks the pipeline raising a ValueError. It does so because the format time expects values of sort "hh:mm:ss", but while the user is running the timer the format is only "hh:mm". In this change I've simply removed all entries who do not conform to the "time" format. These values should never be more than the number of users currently running a timer, as once they end it the time format becomes "hh:mm:ss"

Rollback steps

singer-bot commented 1 year ago

Hi @Jaglyser, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

singer-bot commented 1 year ago

You did it @Jaglyser!

Thank you for signing the Singer Contribution License Agreement.