singer-io / tap-jira

A Singer.io tap for extracting data from the JIRA API
GNU Affero General Public License v3.0
35 stars 54 forks source link

Basic auth will be deprecated #43

Open atmartins opened 5 years ago

atmartins commented 5 years ago

Per https://developer.atlassian.com/cloud/jira/platform/deprecation-notice-basic-auth-and-cookie-based-auth/, basic auth will no longer be supported. Suggestion is to replace the basic auth feature here with api token authorization. The readme should be updated as well, with example config.

luandy64 commented 5 years ago

I agree with you on the README update, but only to say that for most people to use OAuth tokens.

We need to keep support for basic auth for the people that run this tap against an on-prem Jira instance. Unless I'm wrong about this.

atmartins commented 5 years ago

Ah okay, that makes sense. I think the Oauth stuff is pretty difficult to set up, as Atlassian doesn't seem to provide all those values in one place, or with those names. Do you think it would be beneficial to add api token authorization in addition to Basic and OAuth? I'm happy to submit a PR soon if you think that is a good idea.

luandy64 commented 5 years ago

Atlassian provides a tutorial on getting the OAuth credentials.

So I think if you go through the tutorial and get these values, then putting those values in a my_tap_config.json should get the tap to run.

If you think the api token auth PR would be easier than the tutorial I linked, feel free to open it.

rpaterson commented 4 years ago

Just tried it and you can specify the auth token instead of password and it works fine. So no code changes needed, maybe just update the README.

diegojardon commented 3 years ago

I've put the auth token in the password field of the config file but still getting no result ("currently_syncing": null) and of course getting no data. Is this behaviour realated to this issue with Basic Authentication on Jira? Has anyone solved it? (I'm using Python 3.9 by the way) Thanks!

KBorders01 commented 3 years ago

@diegojardon did you select any streams in your catalog JSON file? Putting the API token in the password field with basic authentication works for me as of now.