singer-io / tap-linkedin-ads

GNU Affero General Public License v3.0

10 stars 22 forks source link

TDL-13763: Properly handle 4xx responses for adCampaignGroup stream #28

Closed hpatel41 closed 3 years ago

hpatel41 commented 3 years ago

Description of change

TDL-13763: Properly handle 4xx responses for adCampaignGroup stream TDL-13764: Investigate JSON decoding error

Exception handling is updated with proper custom messages as part of TDL-13763 which will also handle JSON decoding errors.

Manual QA steps

Verified that exception is raised with custom error message as per API error code for JSON decoding error.

Rollback steps

revert this branch

hpatel41 commented 3 years ago

This change seems to have lost support for error code 402 - is there a reason why that happened?

@KAllan357 We have followed the documentation for the error handling and we haven't found 402 in the (doc) so we removed it. Let us know if you want to continue adding support for 402.

KAllan357 commented 3 years ago

Tests are failing here after merging master.