singer-io / tap-linkedin-ads

GNU Affero General Public License v3.0

10 stars 22 forks source link

TDL-13963: Improve tap tester coverage #30

Closed hpatel41 closed 3 years ago

hpatel41 commented 3 years ago

Description of change

TDL-13963: Improve tap tester coverage Added

test_discovery
test_sync_canary
test_start_date
test_pagination

Deleted existing test test_sync as the new tests cover all the scenarios.

Manual QA steps

Risks

Rollback steps

revert this branch

hpatel41 commented 3 years ago

One more thing. We just updated the tap-tester image. The new image is 218546966473.dkr.ecr.us-east-1.amazonaws.com/circle-ci:stitch-tap-tester and should be used as the default moving forward for python taps. This new image contains the update run-test script as well. So in the config.yml the tests can be called like this: run-test --tap=tap-linkedin-ads tests.

@kspeer825 Done the changes according to the comment, can you please review the PR