singer-io / tap-linkedin-ads

GNU Affero General Public License v3.0

10 stars 22 forks source link

TDl-20154 dict base to class base implementation #48

Closed prijendev closed 2 years ago

prijendev commented 2 years ago

Description of change

- TDl-20154 dict base to class base implementation

Implemented dict base to class base implementation.
Write down detailed unit test cases and achieve more than 95 percent code coverage.
Made parent and child streams independent of each other.
Remove some of the existing pylint disability.

- TDl-20158 Make parent and child stream indenpendent

When only a child is selected, a record and bookmark for the child stream would be written.
When the parent and child streams both are selected, at that time sync method of the parent would be called only once for both the streams.
Passed all existing test cases in the local.

Note: We have merged changes of PR#38 into this PR.

Manual QA steps

Risks

Rollback steps

revert this branch