singer-io / tap-linkedin-ads

GNU Affero General Public License v3.0
10 stars 22 forks source link

Upgrade Linkedin API version from 202304 to 202403 #69

Closed sgandhi1311 closed 6 months ago

sgandhi1311 commented 6 months ago

Description of change

Manual QA Steps

Risks

Rollback steps

sgandhi1311 commented 6 months ago

Not a blocker to merge this PR but should be considered removing the pivot and pivotValue occurrences if it is not supported anymore.

We can think of it in the future, currently, the fields - pivot and pivotValue are set to automatic. This PR targets to update the API version on priority.

Vi6hal commented 6 months ago

@rdeshmukh15 there are few more deprecations with video_ads stream too, but since the api deprecation deadline is very near, we don't want to remove any schema objects thus avoiding a major version bump. i am going to document these compatibility changes to be removed in the next major release.

Can you please approve this PR?