singer-io / tap-mysql

Singer.io Tap for MySQL

GNU Affero General Public License v3.0

52 stars 52 forks source link

Fix/binlog empty update #124

Closed luandy64 closed 4 years ago

luandy64 commented 4 years ago

Description of change

The tap can error because mysql-replication- the library we use to handle binlog syncs- throws an IndexError while reading the columns.

QA steps

[ ] automated tests passing
[x] manual qa steps passing (list below)
- Ran the tap without this code, watched it fail
- Ran the tap with the code and complete a sync successfully

Risks

Low: The error seems to only occur with update events. And if it's true that the updates with 0 affected rows are causing the error, then it doesn't seem like we'll lose any data

Rollback steps

revert this branch

luandy64 commented 4 years ago

Closing this for a different approach