search

singer-io / tap-nice-incontact

GNU Affero General Public License v3.0
5 stars 4 forks source link

Unused class #2

Open luandy64 opened 3 years ago

luandy64 commented 3 years ago

Every stream seems to be an Incremental stream. So we don't need this Full Table stream class

https://github.com/singer-io/tap-nice-incontact/blob/f9939c86b4fac5de5ce22d11e5d1927edcf995b0/tap_nice_incontact/streams.py#L170-L206

loeakaodas commented 3 years ago

The Base, Full/Incremental table classes are part of the cookie cutter template we use. While the current set of streams do not require a full table sync there are other endpoints in the API that will when implemented.