singer-io / tap-outreach

GNU Affero General Public License v3.0

6 stars 21 forks source link

Add name to events schema #10

Closed thaipablo closed 3 years ago

thaipablo commented 3 years ago

Description of change

Add name to events schema

Manual QA steps

reviewed rest of repo for how change would affect rest of tap, appears that simply adding the field in the schema should suffice

Risks

I am not a developer so there is risk that I misinterpreted the code
I have not run the code locally as a unit test (I'm not a developer)

Rollback steps

revert this branch

cmerrick commented 3 years ago

Hi @thaipablo, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

cmerrick commented 3 years ago

You did it @thaipablo!

Thank you for signing the Singer Contribution License Agreement.

mormelad commented 3 years ago

hi @cmerrick would appreciate your help here, what else is needed to merge this PR?