singer-io / tap-outreach

GNU Affero General Public License v3.0
6 stars 21 forks source link

`updaterId` exists as both an attribute and generated relationship name #20

Closed asharmaupland closed 1 year ago

asharmaupland commented 1 year ago

2022-12-15 17:46:46,795Z tap - File "/code/orchestrator/tap-env/lib/python3.9/site-packages/tap_outreach/init.py", line 46, in main 2022-12-15 17:46:46,795Z tap - sync(client, 2022-12-15 17:46:46,795Z tap - File "/code/orchestrator/tap-env/lib/python3.9/site-packages/tap_outreach/sync.py", line 336, in sync 2022-12-15 17:46:46,795Z tap - sync_endpoint(client, config, catalog, state, 2022-12-15 17:46:46,795Z tap - File "/code/orchestrator/tap-env/lib/python3.9/site-packages/tap_outreach/sync.py", line 313, in sync_endpoint 2022-12-15 17:46:46,795Z tap - max_modified = process_records(stream, 2022-12-15 17:46:46,795Z tap - File "/code/orchestrator/tap-env/lib/python3.9/site-packages/tap_outreach/sync.py", line 231, in process_records 2022-12-15 17:46:46,795Z tap - raise Exception( 2022-12-15 17:46:46,795Z tap - Exception: updaterId exists as both an attribute and generated relationship name 2022-12-15 17:46:46,829Z target - INFO Requests complete, stopping loop 2022-12-15 17:46:46,868Z main - INFO Target exited normally with status 0 2022-12-15 17:46:47,564Z main - INFO [smart-services] event successfully sent to kafka: com.stitchdata.extractionJobFinished [4] at offset None 2022-12-15 17:46:47,566Z main - INFO No tunnel subprocess to tear down 2022-12-15 17:46:47,566Z main - INFO Exit status is: Discovery succeeded. Tap failed with code 1 and error message: "updaterId exists as both an attribute and generated relationship name". Target succeeded.

asharmaupland commented 1 year ago

We encountered an error while replicating data from Outreach The message is : updaterId exists as both an attribute and generated relationship name Please help to solve the problem

5amCurfew commented 1 year ago

We are also running into this. Given that previously Outreach made updates to similar issues quickly (ref. github.com/singer-io/tap-outreach/issues/16#issuecomment-1034007811) we are going to wait over the weekend expecting a fix (the tap probably assumes that attributes and relationships are mutually exclusive).

If we don't see a change soon we are most likely going to just remove the if fk_field_name in record_flat: block here github.com/singer-io/tap-outreach/blob/d3ad0ee815c0d4261385576ff235f93efb1ad176/tap_outreach/sync.py#L230 as we don't mind relationships taking precedence over attributes (removing if fk_field_name in record_flat: block will lead to it being over written by relationships).

scottoneto commented 1 year ago

Following this thread as I am experiencing the same "updaterId exists as both an attribute and generated relationship name" issue replicating data from our Outreach.io account.

fidel-perez commented 1 year ago

We have encountered this issue too. I am assuming more messages like this one do not contribute any further to the conversation so let's just react with an emoji to this message or @scottoneto message if you came here for the same reason.

asharmaupland commented 1 year ago

Any Update on this @5amCurfew

asharmaupland commented 1 year ago

Hi @5amCurfew

Have you implemented this ''remove the if fk_field_name in record_flat''??

5amCurfew commented 1 year ago

We have just commented out the block as mentioned above letting the relationship value of it take precedence over the attribute value. No issues by the looks of it with respect to the catalog etc

asharmaupland commented 1 year ago

@5amCurfew It is fixed or you are going to fix it. I am still getting the same error .

New Log:

2023-01-04 10:45:56,388Z tap - INFO replicated 0 records from "prospects" endpoint 2023-01-04 10:45:56,389Z tap - CRITICAL updaterId exists as both an attribute and generated relationship name 2023-01-04 10:45:56,389Z tap - Traceback (most recent call last): 2023-01-04 10:45:56,389Z tap - File "/code/orchestrator/tap-env/bin/tap-outreach", line 33, in 2023-01-04 10:45:56,389Z tap - sys.exit(load_entry_point('tap-outreach==0.7.0', 'console_scripts', 'tap-outreach')()) 2023-01-04 10:45:56,389Z tap - File "/code/orchestrator/tap-env/lib/python3.9/site-packages/singer/utils.py", line 229, in wrapped 2023-01-04 10:45:56,389Z tap - return fnc(*args, **kwargs) 2023-01-04 10:45:56,389Z tap - File "/code/orchestrator/tap-env/lib/python3.9/site-packages/tap_outreach/init.py", line 46, in main 2023-01-04 10:45:56,389Z tap - sync(client, 2023-01-04 10:45:56,390Z tap - File "/code/orchestrator/tap-env/lib/python3.9/site-packages/tap_outreach/sync.py", line 336, in sync 2023-01-04 10:45:56,390Z tap - sync_endpoint(client, config, catalog, state, 2023-01-04 10:45:56,390Z tap - File "/code/orchestrator/tap-env/lib/python3.9/site-packages/tap_outreach/sync.py", line 313, in sync_endpoint 2023-01-04 10:45:56,390Z tap - max_modified = process_records(stream, 2023-01-04 10:45:56,390Z tap - File "/code/orchestrator/tap-env/lib/python3.9/site-packages/tap_outreach/sync.py", line 231, in process_records 2023-01-04 10:45:56,390Z tap - raise Exception( 2023-01-04 10:45:56,390Z tap - Exception: updaterId exists as both an attribute and generated relationship name 2023-01-04 10:45:56,421Z target - INFO Requests complete, stopping loop 2023-01-04 10:45:56,461Z main - INFO Target exited normally with status 0 2023-01-04 10:45:56,464Z main - INFO No tunnel subprocess to tear down 2023-01-04 10:45:56,464Z main - INFO Exit status is: Discovery succeeded. Tap failed with code 1 and error message: "updaterId exists as both an attribute and generated relationship name". Target succeeded.

5amCurfew commented 1 year ago

We have forked the singer tap expecting it to be fixed/resolved by updates to the Outreach API at some point given previous updates (refer to github.com/https://github.com/singer-io/tap-outreach/issues/16#issuecomment-1034007811)

seanlally commented 1 year ago

Joining in late here, but does this mean this issue won't be fixed until it is fixed on Outreach's end? We are experiencing the same error.

seanlally commented 1 year ago

@5amCurfew

From outreach support directly:

Thanks for additional details and context!

I heard back from the team and it looks like we recently pushed this field to production, however it is not a stable feature yet.

I also did some testing myself, and I can fetch prospects with that field via API. We don't partner with Stitch at the moment so we don't have any visibility on this integration. But it looks like they might enforce a set of fields from their end and that would be the reason of this error. I would recommend reaching out to them directly since they own the integration and they should have more insight of what is going on.

From the Outreach side, I can confirm, that is a new field, it is still in the development but it shouldn't fail when retrieving data via API.

I wish I could help more. Please let me know if you or Stitch team have any questions, more than happy to schedule some time to troubleshoot together if I can help in any way.

scottoneto commented 1 year ago

@seanlally This is an integration that is run within Stitch, but Stitch does not actively support it by their team. Maintenance (and support) of this integration are performed by the Singer community, including bug fixing/adapting to new versions of the API. Our team is still experiencing the issue as well, but hoping it gets rectified or we will end up putting in our own pull request.

seanlally commented 1 year ago

Yes, the point of the outreach support post was to show that Outreach won't be fixing this on their end, because to them it is working as expected. 5am's last message made it sound like they were just going to wait for Outreach to fix it, which isn't going to happen.

asharmaupland commented 1 year ago

@seanlally @5amCurfew Is there an ETA on this fix?

asharmaupland commented 1 year ago

@seanlally @5amCurfew Any update on this issue?

asharmaupland commented 1 year ago

Any update on this? @seanlally @5amCurfew

joe-rayment commented 1 year ago

We are also experiencing this issue. We went through a back and forth with Stitch Support and they suggested we raise it here

seanlally commented 1 year ago

There are two outstanding PRs that attempt to fix this issue. We're just waiting for either one of them to be reviewed and accepted.

asharmaupland commented 1 year ago

@seanlally Is there an ETA on this fix? This is very critical for our business.

seanlally commented 1 year ago

No idea, just waiting for singer.io folks to do something.

asharmaupland commented 1 year ago

@luandy64 Is there an ETA on this fix? This is very critical for our business. This is pending from last 3 months. For outreach integration we are using stitch API. Can you please help us on this ASAP?

charlie-mclaughlin commented 1 year ago

I've been following along for the last few months as well, is there any evidence that singer.io is still a functioning group? Seems like the lights are on (the website works) but no one is home. I appreciate @seanlally trying a PR, but we might be better off just creating our own API requests to Outreach.

asharmaupland commented 1 year ago

@seanlally Any update on this?

seanlally commented 1 year ago

Still haven't heard anything from singer-io. We use this tap through Stitch and they said they can't do anything from their end. They suggested we slack or tweet singer-io, but the singer-io twitter account has been idle for 3 years and the slack link on the singer-io webpage is broken (for me at least).

g-chris commented 1 year ago

@seanlally I was able to get into the Singer slack and raised your PR to someone in that channel I saw responding to another PR.

Thank you for all the work you've put in on this, along with everyone else for raising this issue.

This is the slack link that worked for if anyone else wants to join: https://singer-slackin.herokuapp.com/

ismael-contentful commented 1 year ago

Any luck @g-chris ? We are having the same issue for months now too.

Thanks for raising it in the Slack channel.

charlie-mclaughlin commented 1 year ago

In case anyone else is trying to bring this data to Snowflake, I'm having more luck with getting Outreach data directly from Snowflake Marketplace.

g-chris commented 1 year ago

Any luck @g-chris ? We are having the same issue for months now too.

@ismael-contentful I got a reply 18 days ago that they would review it soon but looks like it hasn't happened yet so I asked for an update today, will report back.

asharmaupland commented 1 year ago

@5amCurfew @seanlally Do you have any idea about this issue?

2023-04-24 06:54:42,079Z tap - response.raise_for_status() 2023-04-24 06:54:42,079Z tap - File "/code/orchestrator/tap-env/lib/python3.9/site-packages/requests/models.py", line 941, in raise_for_status 2023-04-24 06:54:42,079Z tap - raise HTTPError(http_error_msg, response=self) 2023-04-24 06:54:42,079Z tap - requests.exceptions.HTTPError: 400 Client Error: Bad Request for url: https://api.outreach.io/oauth/token 2023-04-24 06:54:42,079Z tap - 2023-04-24 06:54:42,079Z tap - During handling of the above exception, another exception occurred: 2023-04-24 06:54:42,079Z tap - 2023-04-24 06:54:42,080Z tap - Traceback (most recent call last): 2023-04-24 06:54:42,080Z tap - File "/code/orchestrator/tap-env/bin/tap-outreach", line 33, in 2023-04-24 06:54:42,080Z tap - sys.exit(load_entry_point('tap-outreach==0.7.0', 'console_scripts', 'tap-outreach')()) 2023-04-24 06:54:42,080Z tap - File "/code/orchestrator/tap-env/lib/python3.9/site-packages/singer/utils.py", line 229, in wrapped 2023-04-24 06:54:42,080Z tap - return fnc(*args, **kwargs) 2023-04-24 06:54:42,080Z tap - File "/code/orchestrator/tap-env/lib/python3.9/site-packages/tap_outreach/init.py", line 45, in main 2023-04-24 06:54:42,080Z tap - check_auth(client) 2023-04-24 06:54:42,080Z tap - File "/code/orchestrator/tap-env/lib/python3.9/site-packages/tap_outreach/init.py", line 33, in check_auth 2023-04-24 06:54:42,080Z tap - raise Exception('Error testing Outreach authentication') 2023-04-24 06:54:42,080Z tap - Exception: Error testing Outreach authentication 2023-04-24 06:54:42,109Z target - INFO Requests complete, stopping loop 2023-04-24 06:54:42,148Z main - INFO Target exited normally with status 0 2023-04-24 06:54:42,151Z main - INFO No tunnel subprocess to tear down 2023-04-24 06:54:42,151Z main - INFO Exit status is: Discovery succeeded. Tap failed with code 1 and error message: "Error testing Outreach authentication". Target succeeded.

asharmaupland commented 1 year ago

@seanlally @sgandhi1311 Any update on this?

sgandhi1311 commented 1 year ago

Hello @asharmaupland, I see the OAuth app side issue is fixed. I will review this PR - https://github.com/singer-io/tap-outreach/pull/21 and push the changes in the prod.

sgandhi1311 commented 1 year ago

@asharmaupland The fix provided by @seanlally #25 is deployed to prod. Please validate whether you are getting the expected results.

g-chris commented 1 year ago

@asharmaupland The fix provided by @seanlally #25 is deployed to prod. Please validate whether you are getting the expected results.

I'm now seeing up to date data on the prospect table so looks like the fix worked.

Thank you @sgandhi1311 and @seanlally!

ismael-contentful commented 1 year ago

It also works now for us. Thanks @sgandhi1311 and @seanlally !

asharmaupland commented 1 year ago

It is working Now. Thanks @seanlally @sgandhi1311 !

seanlally commented 1 year ago

Yay, it's working. Thanks everyone!