singer-io / tap-outreach

GNU Affero General Public License v3.0
6 stars 21 forks source link

Change pagination from offset to cursor, rate limiting. #5

Closed jeffhuth-bytecode closed 4 years ago

jeffhuth-bytecode commented 4 years ago

Description of change

Change from offset to cursor pagination in sync.py. Add rate limit decorator to client.py.

Manual QA steps

Ran singer-discover, singer-check-tap, and target-stitch (initial load and incremental).

Risks

Low - removes potential 10,000 limit and possible infinite loop w/ offset pagination. Tested multiple pages but not with large data volumes.

Rollback steps

Revert to 0.3.0