singer-io / tap-outreach

GNU Affero General Public License v3.0

6 stars 21 forks source link

Configure page size #7

Closed luandy64 closed 4 years ago

luandy64 commented 4 years ago

Description of change

This PR is all of the work in #6, but pushed here so that tests could run and I could add the int(config.get('page_size'))

Manual QA steps

Ran the tap

Risks

Low
- If you don't have page_size in your config, there's a default value
- If you do have it, we can use it whether the type of the value is a string or an int
  - Not sure what a float would do here - Would the API error if the requests send in a float?

Rollback steps

revert this branch, bump the version