search

singer-io / tap-pipedrive

A Singer.io tap for extracting data from the Pipedrive API
GNU Affero General Public License v3.0
13 stars 34 forks source link

Support for null/empty org names in notes #104

Open b-luu opened 3 years ago

b-luu commented 3 years ago

Description of change

In natural (in the wild) Pipedrive usage, we can encounter Organization names that aren't (yet) filled in at the time a note is created on Pipedrive. The current jsonschema rejects such records, which makes the whole sync fail and stop instantly ! Here we're expanding the support by adding null type to organization.name (sub)property.

Manual QA steps

Risks

Rollback steps

cmerrick commented 3 years ago

Hi @b-luu, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

cmerrick commented 3 years ago

You did it @b-luu!

Thank you for signing the Singer Contribution License Agreement.

b-luu commented 3 years ago

Hello @luandy64

Can you have a quick look please ?

This is litterally a oneliner and only touches one schema file. While it's a blocker on my end to be able to use the Pipedrive connector correctly on Stitch...

Thanks !!

Cheers, Brice

b-luu commented 2 years ago

Hey @cmerrick

What's the process to have this merged ?

Thanks for your help!

Cheers, Brice