singer-io / tap-postgres

tap-postgres
GNU Affero General Public License v3.0
67 stars 62 forks source link

multipleOf validation on M1 Macs #141

Open cdscih opened 1 year ago

cdscih commented 1 year ago

https://github.com/singer-io/tap-postgres/blob/926b5d3a6f53f8d51057c404b2b51c93ae09f0a7/tap_postgres/__init__.py#L113

This "multipleOf" validation seems to give problems with M1 processors.

Me, and my colleagues @omarghetti and @PaoloAlbano, found this issue while trying to import data from a Postgres Datasource having some columns of type "number".

What's the reason to have such validation check? We found our usecases to work as expected in all scenarios by simply removing it.

We run this code on docker containers running the official python:3.6 and python:3.5 images.