search

singer-io / tap-ringcentral

Singer.io tap for RingCentral
GNU Affero General Public License v3.0
3 stars 10 forks source link

Adding Detailed Company Call Log #10

Open KolinMboorom opened 3 years ago

KolinMboorom commented 3 years ago

I would branch and make a PR but I don't currently have access

Expected Behavior

Our company needs the ability to track how many of our outgoing and incoming calls are being recorded. This can be done using the Recordings object found in a Detailed GET request. In order to access the recordings object the GET request must be altered to add the view = "Detailed" and the withRecording=true parameters. All of the items within the Recording object are desired.

image

image

Current Behavior

Company_Call_log.py line 17 @property def api_path(self): return '/restapi/v1.0/account/~/call-log'

The above code must be modified because it doesn't allow for desired parameters. A possible solution is listed below

Possible Solution

company_call_log.py line 17 @property def api_path(self): return '/restapi/v1.0/account/~/extension/{extensionId}/call-log?view=Detailed&withRecording=true'

company_call_log.json Line 29 Addition

"recording": { "type": ["null", "string"] },

catalog.json line 518 Addition

"recording": { "type": [ "null", "string" ] },

Context

We have no ability to track what % of calls are being recorded for future analysis. All advanced analytical capabilities can't be properly assessed without the basic ability to report on call recording stats.

twcurrie commented 3 years ago

@KolinMboorom Can you make a fork of this repo and write your PR from that?

KolinMboorom commented 3 years ago

@KolinMboorom Can you make a fork of this repo and write your PR from that?

Yes, putting it together now

shedd commented 3 years ago

Thanks @KolinMboorom for preparing the PR #12!

@twcurrie any insight into how these get reviewed? In addition to fixing this issue, I think #12 also fixes #6 and #7, but it's unclear how/when/if Stitch reviews these to pull the updates into their platform.

twcurrie commented 3 years ago

@shedd It's a good question. Maybe some of the last commiters, like @KAllan357, @drewbanin, @nick-mccoy could offer clarity?

I don't work for Stitch, but am interested in seeing this plugin get better maintenance. I'm in the slack workspace for singer.io and I can ping them there as well.