Open alexguanga opened 4 years ago
Hi @alexguanga, thanks for your contribution!
In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.
You did it @alexguanga!
Thank you for signing the Singer Contribution License Agreement.
@cmerrick - Following up on the PR, is there any additional specification/requirements I should follow? Thanks!
Hello, Any news on this?
Hello, Any news on this?
Nope, have not heard any updates.
Description of change
Introduced functionality to bypass the
stream_is_selected
by passing an argument in theconfig.json
when running the--properties
flag.Desired Exact code change
Why Are We Proposing the Change?
--discover
nor the--properties
flag. Instead, we are piping the data from the Tap to the Target with the--config
flag directly.--config
, we need to execute the functionality of the--discover
and--properties
in one sync and not two.About the Desired Code Change
true
for theskip_stream_is_selected
in the config.sample.json, we are able to bypass the--properties
and--discover
flag.--properties
and--discover
flag. The difference is that we performing this with only the--config
flag. To be able to this, we can either:--properties
stream_is_selected
flag, it will bypass thestream_is_selected
if operation.Workflow - Please note that the workflow is an addition to what's provided by singer's io tap-s3-csv, it does not affect any current workflows.
skip_stream_is_selected
totrue
in theconfig.json
tap-s3-csv --config config.json
Manual QA steps
Risks
Rollback steps