Strictly enforce the ordering of type checking for integer vs number. Differences in python versions can cause differences in the ordering of maps, relying on the ordering of maps is unreliable. The map was causing float to take precedence over integer in certain python versions.
Manual QA steps
Ran the tap many times. Without this change and running python 3.5.2 caused the float to come first in the iteration over the map, while running it in python 3.8.0 had int come first. With this change it is consistent ordering across python versions.
Description of change
Strictly enforce the ordering of type checking for integer vs number. Differences in python versions can cause differences in the ordering of maps, relying on the ordering of maps is unreliable. The map was causing
floatto take precedence overintegerin certain python versions.Manual QA steps
floatto come first in the iteration over the map, while running it in python 3.8.0 hadintcome first. With this change it is consistent ordering across python versions.Risks
Rollback steps