singer-io / tap-salesforce

Singer.io tap for the Salesforce API
GNU Affero General Public License v3.0
78 stars 71 forks source link

Add custom object to saleseforce account and update base to match #166

Closed bhtowles closed 1 year ago

bhtowles commented 1 year ago

Description of change

Add custom objects to expected metadata

QA steps

Risks

Rollback steps

bhtowles commented 1 year ago

Curious what tests this would be picked up in? I assume discovery automatically, but are there any others or is that being done separately?

Also, it looks like two tests are failing in discovery for some reason.

From the build_daily it looks like discovery rest, discovery bulk, and table reset. Not sure why table reset is picking this up automatically but there are new edits / tests planned to explicitly pick up these custom streams before closing this card. This first merge is just to fix the existing tests. There will be a separate PR for the new / modified tests.

EDIT: Looks like the table reset case is running the base suite test that asserts found catalogs are all expected. Makes sense why this one is impacted now.