singer-io / tap-shopify

Singer.io tap for extracting Shopify data

GNU Affero General Public License v3.0

57 stars 89 forks source link

TDL-6553: Add shop info in record - (Copy of PR 73) #115

Closed savan-chovatiya closed 3 years ago

savan-chovatiya commented 3 years ago

Description of change

TDL-6553: Add shop info to the records

QA steps

[x] automated tests passing
[x] manual qa steps passing (list below)
- Verified that all three fields related to shop information are emitted for every stream if selected in the catalog.
- Verified that all three fields related to shop information are skipped if not selected in the catalog

Risks

Rollback steps

revert this branch

savan-chovatiya commented 3 years ago

Remove this function add_synthetic_keys_to_schema and hardcode the schema for new SDC fields and make sure that the tests are passing

The function add_synthetic_keys_to_schema() is adding _sdc fields to all the streams schema. If we remove it and add those fields directly in schema JSON files then we have to add those fields in newly added streams as well. eg. In newly added 3 streams as part #114 and #118 And if any new streams are added in the future, the developer needs to add these fields to the new stream schema as well.

savan-chovatiya commented 3 years ago

This is a good tap-tester test for this change. But may want to consider adding unittests if you are going to stick with this dynamic approach.

Added unittest for add_synthetic_keys_to_schema() function.