search

singer-io / tap-taboola

A Singer tap for extracting data from the Taboola API
GNU Affero General Public License v3.0
2 stars 11 forks source link

API doesn't bring any data when adding the field "name" (Campaign name) #2

Open yomarcos2 opened 6 years ago

yomarcos2 commented 6 years ago

Our requests against Taboola's API appear to be successful, but Taboola's API is not returning any values, 0 results

dsprayberry commented 6 years ago

Posting to clarify points discussed outside of Github:

tap-taboola makes requests against two different endpoints of Taboola's API, and requests made to get-campaigns using @yomarcos2 credentials return a 200 response with an empty set, which is indicative of this issue where the source Taboola account is not an "advertiser" type.

The campaign_performance table makes requests against Taboola's Reports API using the campaign_day_breakdown. According to Taboola's docs, this breakdown should return the dimension columns:

date (Type: Date ISO-8601; Description: exact date for day dimension. beginning of period for week/month dimensions) campaign (Type: Long; Description: ID of Campaign in question) campaign_name (Type: String; Description: Human-readable campaign name)

The values expected to be returned do not include campaign_name, and if it is indeed being provided by Taboola's API, persisting this value would improve the usability of the tap for those with non-advertiser Taboola accounts.